Skip to content

Expose CorrectHomographNumbers publicly on ILexEntry#375

Merged
myieye merged 2 commits into
masterfrom
expose-correct-homograph-numbers
May 19, 2026
Merged

Expose CorrectHomographNumbers publicly on ILexEntry#375
myieye merged 2 commits into
masterfrom
expose-correct-homograph-numbers

Conversation

@myieye
Copy link
Copy Markdown
Contributor

@myieye myieye commented May 13, 2026 •
edited by ddaspit
Loading

Adds ILexEntry.CorrectHomographNumbers() which wraps the existing LexDb.CorrectHomographNumbers algorithm.
FieldWorks Lite writes HomographNumber directly and needs a way to trigger a "cleanup" of a potentially broken homograph sequence.

This change is Reviewable

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 13, 2026 •
edited
Loading

LCM Tests

    16 files  ±0      16 suites  ±0   3m 13s ⏱️ +16s
 2 860 tests +2   2 840 ✅ +2   20 💤 ±0  0 ❌ ±0 
11 388 runs  +8  11 220 ✅ +8  168 💤 ±0  0 ❌ ±0 

Results for commit b46e645. ± Comparison against base commit 66da667.

♻️ This comment has been updated with latest results.

jasonleenaylor
jasonleenaylor requested changes May 13, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@jasonleenaylor jasonleenaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From an API standpoint I don't like adding a method on LexEntry which modifies data in other LexEntries. This should be exposed, but I don't think it belongs here.

@jasonleenaylor reviewed all commit messages and made 1 comment.
Reviewable status: 0 of 3 files reviewed, all discussions resolved.

@myieye
Copy link
Copy Markdown
Contributor Author

myieye commented May 15, 2026

@jasonleenaylor You're right. I moved it.

API-wise it would be arguably better to make the signature of my new method more similar to CollectHomographs in that it just takes a string form and morph-type. But it would be a bit awkward if it couldn't be used to correct blank-form entries. To do that it obviously needs the entry itself. If you're unhappy with it taking an entry and then also editing other entries. Then I can change it and make FW Lite handle the blank-form case. The current code would just be a bit more handy for us.

@myieye myieye requested a review from jasonleenaylor May 15, 2026 10:07
jasonleenaylor
jasonleenaylor approved these changes May 19, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@jasonleenaylor jasonleenaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@jasonleenaylor reviewed 4 files and all commit messages, and made 1 comment.
Reviewable status: 4 of 5 files reviewed, all discussions resolved.

@myieye myieye merged commit 1659ac7 into master May 19, 2026
4 of 5 checks passed
@myieye myieye deleted the expose-correct-homograph-numbers branch May 19, 2026 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasonleenaylor jasonleenaylor jasonleenaylor approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@myieye @jasonleenaylor